[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors

[George Rimar via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/InputFiles.cpp:411
+    auto *D = dyn_cast<DefinedRegular<ELFT>>(B);
+    if (!D)
+      continue;
----------------
May be 

```
if (!D || D->Section != S)
```


================
Comment at: ELF/Relocations.cpp:543
+  return (SrcFile + " (" + S.Name + "+0x" + Twine::utohexstr(Offset) + ")")
+      .str();
+}
----------------
Looks you do not need .str() here.


https://reviews.llvm.org/D25826