[PATCH] D25506: [LCG] Add utilities to compute parent and ascestor relationships between SCCs.

[Sanjoy Das via llvm-commits]

sanjoy requested changes to this revision.
sanjoy added a subscriber: mzolotukhin.
sanjoy added a comment.
This revision now requires changes to proceed.

I'm in favor of adding this -- IME verification like this has always paid off (recent examples include the LCSSA verification that @mzolotukhin has been working on).

I do have one comment inline.



================
Comment at: lib/Analysis/LazyCallGraph.cpp:212
+  SmallPtrSet<Node *, 16> Visited(Nodes.begin(), Nodes.end());
+  SmallVector<Node *, 16> Worklist(Nodes.begin(), Nodes.end());
+
----------------
Why not walk over `SCC` instances directly?  The way you've written these, I think you'll spend time "re-discovering" the SCC structures (that is walking intra-SCC call edges) when that is avoidable.


https://reviews.llvm.org/D25506