[PATCH] D25583: Timer: Track Name and Description.

[Vedant Kumar via llvm-commits]

vsk added a comment.

This looks good! I only have nits. I assume clang will need some updates when you land this?



================
Comment at: lib/IR/LegacyPassManager.cpp:452
   // Use 'create' member to get this.
-  TimingInfo() : TG("... Pass execution timing report ...") {}
+  TimingInfo() : TG("pass", "... Pass execution timing report ...") {}
 
----------------
Bikeshed: maybe "timing_info" for the name here? (I don't have a hard '-1' to just keeping "pass".)


================
Comment at: lib/Support/Timer.cpp:214
 static ManagedStatic<Name2PairMap> NamedGroupedTimers;
 
+NamedRegionTimer::NamedRegionTimer(StringRef Name, StringRef Description,
----------------
getNamedRegionTimer has no coverage -- it looks safe to delete in a prep commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D25583