[PATCH] D25374: [DAGCombiner] Update most ADD combines to support general vector combines

[Simon Pilgrim via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:859
+    ConstantSDNode *Const = dyn_cast<ConstantSDNode>(Op);
+    if (!Const || Const->isOpaque() ||
+        Const->getAPIntValue().getBitWidth() != BitWidth)
----------------
mkuper wrote:
> Maybe merge isConstantOrConstantVector and isNonOpaqueConstantOrNonOpaqueConstantVector and have a nonOpaque parameter?
Will do - it'll help reduce the length of those function names!


Repository:
  rL LLVM

https://reviews.llvm.org/D25374