[PATCH] D25374: [DAGCombiner] Update most ADD combines to support general vector combines
Michael Kuperstein via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 10 12:14:09 PDT 2016
mkuper added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:859
+ ConstantSDNode *Const = dyn_cast<ConstantSDNode>(Op);
+ if (!Const || Const->isOpaque() ||
+ Const->getAPIntValue().getBitWidth() != BitWidth)
----------------
Maybe merge isConstantOrConstantVector and isNonOpaqueConstantOrNonOpaqueConstantVector and have a nonOpaque parameter?
Repository:
rL LLVM
https://reviews.llvm.org/D25374
More information about the llvm-commits
mailing list