[PATCH] D25257: Use StringRef in Option library instead of raw pointers (NFC)

[Zachary Turner via llvm-commits]

rnk is OOO until tomorrow btw.

On Mon, Oct 10, 2016 at 1:00 AM Manuel Klimek <klimek at google.com> wrote:

> klimek added a comment.
>
> Drive-by comment regarding the process of creating changes like this:
> In our somewhat larger codebase we've found that the best way to create
> this type of CL is by writing a clang tool:
>
> - the clang tool can be reviewed on its own, and behavior can be bikeshed
> on the tests
> - it's easy to re-run a clang tool on a subset of the interfaces to
> produce any size CL you want
> - if you can make it (or convert it into) a clang-tidy check with a fixit,
> we prevent regressions
>
> That said, if others are fine reviewing this change I'm fine with it; this
> is mainly an idea for the future :)
>
>
> https://reviews.llvm.org/D25257
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161010/038763c5/attachment.html>