[PATCH] D25257: Use StringRef in Option library instead of raw pointers (NFC)

Manuel Klimek via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 01:00:36 PDT 2016


klimek added a comment.

Drive-by comment regarding the process of creating changes like this:
In our somewhat larger codebase we've found that the best way to create this type of CL is by writing a clang tool:

- the clang tool can be reviewed on its own, and behavior can be bikeshed on the tests
- it's easy to re-run a clang tool on a subset of the interfaces to produce any size CL you want
- if you can make it (or convert it into) a clang-tidy check with a fixit, we prevent regressions

That said, if others are fine reviewing this change I'm fine with it; this is mainly an idea for the future :)


https://reviews.llvm.org/D25257





More information about the llvm-commits mailing list