[PATCH] D18544: TypeBuilder: Use parameter pack to permit any number of function parameters

[Lang Hames via llvm-commits]

lhames added a comment.

Oops - missed an inline comment in my previous submit.



================
Comment at: unittests/IR/TypeBuilderTest.cpp:138-175
+  params.push_back(TypeBuilder<char, false>::get(getGlobalContext()));
+  EXPECT_EQ(FunctionType::get(Type::getInt8Ty(getGlobalContext()), params, false),
+            (TypeBuilder<int8_t(int32_t*, void*, char, char, char, char),
+                         false>::get(getGlobalContext())));
+  EXPECT_EQ(FunctionType::get(Type::getInt8Ty(getGlobalContext()), params, true),
+            (TypeBuilder<int8_t(int32_t*, char*, char, char, char, char, ...),
+                         false>::get(getGlobalContext())));
----------------
I don't think you need the additional test cases - the existing ones should provide enough coverage.


https://reviews.llvm.org/D18544