[PATCH] D18544: TypeBuilder: Use parameter pack to permit any number of function parameters

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 8 21:44:53 PDT 2016


lhames added a reviewer: chandlerc.
lhames added a comment.

A couple of comments inline. Otherwise this looks good to me, but I don't own TypeBuilder. I *think* that would be Chandler. Chandler any thoughts?



================
Comment at: include/llvm/IR/TypeBuilder.h:255-271

----------------
I would name the variadic parameter 'As' (plural) rather than 'A'.


https://reviews.llvm.org/D18544





More information about the llvm-commits mailing list