[PATCH] D25300: ThinLTO: handles modules with empty summaries

[Teresa Johnson via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with new test described below.



================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:239
+      // The module does not have an entry, it can't have a hash at all
+      return;
+
----------------
mehdi_amini wrote:
> tejohnson wrote:
> > mehdi_amini wrote:
> > > Is your question referring to this line?
> > > 
> > > If there is no entry for the module, it means it does not have a hash.
> > Yes and I asked the wrong question, since with this patch modules without a summary will now get a hash and be able to be cached. 
> > 
> > So I guess my remaining question is when do we not have an entry here after this patch (as opposed to a 0 valued hash)?
> A module with an empty summary and no hash.
Ok, can you add that case to the new test?


https://reviews.llvm.org/D25300