[PATCH] D25300: ThinLTO: handles modules with empty summaries

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:239
+      // The module does not have an entry, it can't have a hash at all
+      return;
+
----------------
tejohnson wrote:
> mehdi_amini wrote:
> > Is your question referring to this line?
> > 
> > If there is no entry for the module, it means it does not have a hash.
> Yes and I asked the wrong question, since with this patch modules without a summary will now get a hash and be able to be cached. 
> 
> So I guess my remaining question is when do we not have an entry here after this patch (as opposed to a 0 valued hash)?
A module with an empty summary and no hash.


https://reviews.llvm.org/D25300