[PATCH] D24706: [ELF] - Partial support of --gdb-index command line option (Part 1).

[Eric Christopher via llvm-commits]

On Thu, Oct 6, 2016 at 9:48 AM George Rimar <grimar at accesssoftek.com> wrote:

> Thanks for explanation, David !
>
> >If other projects are anything to go by, that rarely, if ever, happens.
> So we tend to like to frontload some of this work to avoid >divergence
> which makes the cost more expensive over time and less likely to be done.
> >
> >(see LLDB's use of a fork of the LLVM DWARF parsing logic (well, I think
> LLVM maybe forked LLDB's, but either way) as a >cautionary tale)
>
> I understand your conserns. But looking on full version of functionality
> (D24267), I see that linker
> needs just a little amount of parsing code. And I do not expect we will
> need much more.
> If we one day we will have fast reusable llvm parsers, I think it be not
> hard to switch lld to use them (watching for perfomance changes), but for
> now I think own short implementation that do only things required for
> generation gdb_index fits better.
>
>
There's an assertion here that the current implementation is not fast or
reusable. I'm not sure where that came from or what prompted it.

Could you elaborate more on why you think these things?

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161006/c13fb3b9/attachment.html>