[PATCH] D25132: Invoke add-discriminator at -g0 -fsample-profile

[David Blaikie via llvm-commits]

On Tue, Oct 4, 2016 at 6:51 PM Dehao Chen <danielcdh at gmail.com> wrote:

> danielcdh added inline comments.
>
>
> > probinson wrote in AddDiscriminators.cpp:165
> > Why analyze the CFG to create discriminators that you are not going to
> emit?  What value does that have?  Seems like a waste of time.
>
> For SamplePGO, it uses debug info including discriminator to annotate CFG.
> So even when the discriminator is not emitted, it needs to be used by the
> profile annotator during compilation.
>

I don't fully understand that - but I'll leave that to Diego to crosscheck.

If that's the case, then, yes - we probably want a way to support adding
discriminators for SamplePGO independently of adding (or at least using)
discriminators for DWARF.


>
> https://reviews.llvm.org/D25132
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161005/732a4d44/attachment.html>