[PATCH] D25132: Invoke add-discriminator at -g0 -fsample-profile

[Dehao Chen via llvm-commits]

danielcdh added inline comments.


> probinson wrote in AddDiscriminators.cpp:165
> Why analyze the CFG to create discriminators that you are not going to emit?  What value does that have?  Seems like a waste of time.

For SamplePGO, it uses debug info including discriminator to annotate CFG. So even when the discriminator is not emitted, it needs to be used by the profile annotator during compilation.

https://reviews.llvm.org/D25132