[PATCH] D24459: [SelectionDAGBuilder] Support llvm.flt.rounds on targets where i32 is not legal

[Hal Finkel via llvm-commits]

hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM.



> LegalizeIntegerTypes.cpp:2024
> +  Lo = DAG.getNode(ISD::FLT_ROUNDS_, dl, NVT);
> +  Hi = DAG.getNode(ISD::SRA, dl, NVT, Lo,
> +                   DAG.getConstant(NBitWidth - 1, dl, ShiftAmtTy));

Please add a comment here that you're sign-extending the high part because the value might be -1.

https://reviews.llvm.org/D24459