[PATCH] D25265: [C API] Add test for D25259 and new LLVMIsExact function.

Manuel Jacob via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 07:54:30 PDT 2016


mjacob abandoned this revision.
mjacob added a comment.

I wasn't very happy with the approach already when submitting the patch.

- It adds a new C API function (`LLVMIsExact`) which I don't really care about other than for writing this test.
- It's asymmetric (e.g. missing something like `LLVMSetIsExact`). @deadalnix pointed this out as well.
- LLVMConstExactUDiv is still untested.

I think we need a different approach for testing the C API. Something like calling a bunch of C API functions, dumping the module and checking it with FileCheck.


https://reviews.llvm.org/D25265





More information about the llvm-commits mailing list