[PATCH] D25265: [C API] Add test for D25259 and new LLVMIsExact function.

[Amaury SECHET via llvm-commits]

deadalnix added inline comments.


> Core.h:3003-3004
>  
> +LLVMBool LLVMIsExact(LLVMValueRef V);
> +
>  /* Memory */

Don't put that in the middle of the builder mapping.

> echo.cpp:483
>          LLVMValueRef RHS = CloneValue(LLVMGetOperand(Src, 1));
> -        Dst = LLVMBuildUDiv(Builder, LHS, RHS, Name);
> +        if (LLVMIsExact(Src))
> +            Dst = LLVMBuildExactUDiv(Builder, LHS, RHS, Name);

This begs the question: should this have been done via a SetExact function ?

https://reviews.llvm.org/D25265