[PATCH] D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute

[Victor Leschuk via llvm-commits]

>
> I'd rather not change the API and the bitcode format without a 
> technical need for it. The cost is just too high.
I agree, the patch with reversed API is on its way. We'll have bits in 
API and convert them to bytes when emitting DWARF attribute.
>
> -- adrian
>
>> On Tue, Oct 4, 2016 at 9:47 AM Victor Leschuk 
>> <vleschuk at accesssoftek.com <mailto:vleschuk at accesssoftek.com>> wrote:
>>
>>     vleschuk added inline comments.
>>
>>
>>     > aprantl wrote in DIBuilder.h:139
>>     > What is the motivation to change this to bytes? This kind of
>>     API change looks dangerous to me because frontends won't even get
>>     a type error to notify them that the API has changed.
>>
>>     Hmm, yep, I think you are right. I thought it would be better to
>>     pass bytes from frontend to backend as frontend has special
>>     CharUnits class for this purpose, however such changes in API can
>>     affect another frontends. Will change it back to bits and convert
>>     in backend.
>>
>>     https://reviews.llvm.org/D24425
>>
>>
>>
>

-- 
Best Regards,
Victor

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161004/3509d719/attachment.html>