<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<blockquote
cite="mid:82C82800-50C2-43C0-B9F7-B5E588AAF3F1@apple.com"
type="cite">
<div>
<div><br class="">
</div>
<div>I'd rather not change the API and the bitcode format
without a technical need for it. The cost is just too high.</div>
</div>
</blockquote>
I agree, the patch with reversed API is on its way. We'll have bits
in API and convert them to bytes when emitting DWARF attribute.<br>
<blockquote
cite="mid:82C82800-50C2-43C0-B9F7-B5E588AAF3F1@apple.com"
type="cite">
<div>
<div><br class="">
</div>
<div>-- adrian</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="gmail_quote">
<div dir="ltr" class="">On Tue, Oct 4, 2016 at 9:47 AM
Victor Leschuk <<a moz-do-not-send="true"
href="mailto:vleschuk@accesssoftek.com" class="">vleschuk@accesssoftek.com</a>>
wrote:<br class="">
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">vleschuk
added inline comments.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
> aprantl wrote in DIBuilder.h:139<br
class="gmail_msg">
> What is the motivation to change this to bytes?
This kind of API change looks dangerous to me because
frontends won't even get a type error to notify them
that the API has changed.<br class="gmail_msg">
<br class="gmail_msg">
Hmm, yep, I think you are right. I thought it would be
better to pass bytes from frontend to backend as
frontend has special CharUnits class for this purpose,
however such changes in API can affect another
frontends. Will change it back to bits and convert in
backend.<br class="gmail_msg">
<br class="gmail_msg">
<a moz-do-not-send="true"
href="https://reviews.llvm.org/D24425"
rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D24425</a><br
class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote>
</div>
</div>
</blockquote>
</div>
<br class="">
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Best Regards,
Victor</pre>
</body>
</html>