[PATCH] D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute

[Victor Leschuk via llvm-commits]

vleschuk added inline comments.


> aprantl wrote in DIBuilder.h:139
> What is the motivation to change this to bytes? This kind of API change looks dangerous to me because frontends won't even get a type error to notify them that the API has changed.

Hmm, yep, I think you are right. I thought it would be better to pass bytes from frontend to backend as frontend has special CharUnits class for this purpose, however such changes in API can affect another frontends. Will change it back to bits and convert in backend.

https://reviews.llvm.org/D24425