[PATCH] D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 08:54:52 PDT 2016


aprantl added inline comments.


> DIBuilder.h:139
>      DIDerivedType *createPointerType(DIType *PointeeTy, uint64_t SizeInBits,
> -                                     uint64_t AlignInBits = 0,
> +                                     uint64_t AlignInBytes = 0,
>                                       StringRef Name = "");

What is the motivation to change this to bytes? This kind of API change looks dangerous to me because frontends won't even get a type error to notify them that the API has changed.

https://reviews.llvm.org/D24425





More information about the llvm-commits mailing list