[PATCH] D25172: [MSSA] Initial version of avoiding unnecessary use walks when calling getClobberingMemoryAccess

[Daniel Berlin via llvm-commits]

On Mon, Oct 3, 2016 at 5:09 PM, George Burgess IV <
george.burgess.iv at gmail.com> wrote:

> george.burgess.iv added inline comments.
>
>
> > MemorySSA.cpp:2185
> > +  // Note: Currently, we do not store the optimized def result because
> we'd need
> > +  // a separate field, since we can't use it as the defining access.
> > +  if (StartingAccess->isOptimized())
>
> RE: `Note: ...`: can you bring me through why having this on a Def is
> would be useful?


Oh, it's just more efficient than having a densemap based cache if you can
make it work :)

It's optimally efficient space wise, but  you may pay the price in
invalidaion time.

Is the cache just invalidated too aggressively?


>
https://reviews.llvm.org/D25172
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161003/e14a4489/attachment.html>