[PATCH] D25088: [x86] Fixing PR28755 by precomputing the address used in CMPXCHG8B

[Alexander Ivchenko via llvm-commits]

aivchenk marked 4 inline comments as done.
aivchenk added inline comments.


> qcolombet wrote in cmpxchg8b_alloca_regalloc_handling.ll:21
> Why to you need the regex here?

You mean in the checks related to the first function? Well, I kinda wanted to express that the register that we are doing "lea" to is the same register we use for a memory location in cmpxchg8b. And since we don't hardcode the name of the register in EmitInstrWithCustomInserter, I did it as a regexp for esi/edi.

Although it makes me wonder whether it is valid or not to define/use regexp with the same name lower in the test

https://reviews.llvm.org/D25088