[PATCH] D25088: [x86] Fixing PR28755 by precomputing the address used in CMPXCHG8B

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 09:37:01 PDT 2016


qcolombet added a comment.

Looks pretty good, just one nitpick.



> cmpxchg8b_alloca_regalloc_handling.ll:21
> +; CHECK-NEXT: {{xor|mov}}
> +; CHECK-NEXT: {{xor|mov}}
> +; CHECK-NEXT: lock            cmpxchg8b       ([[REGISTER]])

Why to you need the regex here?

https://reviews.llvm.org/D25088





More information about the llvm-commits mailing list