[PATCH] D24168: Refactor LICM pass in preparation for LoopSink pass.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 11:32:05 PDT 2016


hfinkel added inline comments.


> hfinkel wrote in LICM.cpp:520
> I agree. This makes sense, but please add a comment here, and also a comment in LoopUtils.h for each relevant interface explaining that passing nullptr for SafetyInfo is for sinking.

Yes. The comment before the early return should specifically point out that for sinking we don't need to check isSafeToExecuteUnconditionally.

https://reviews.llvm.org/D24168





More information about the llvm-commits mailing list