[PATCH] D24168: Refactor LICM pass in preparation for LoopSink pass.

[Hal Finkel via llvm-commits]

hfinkel added inline comments.


> chandlerc wrote in LICM.cpp:520
> This is a good question, it may just mean that "SafetyInfo" needs a better name or this needs a comment to explain why this is correct.
> 
> Alternatively, we could require that SafetyInfo is always provided.

I agree. This makes sense, but please add a comment here, and also a comment in LoopUtils.h for each relevant interface explaining that passing nullptr for SafetyInfo is for sinking.

https://reviews.llvm.org/D24168