[PATCH] D25136: [Triple] Add Facebook vendor

[Daniel Berlin via llvm-commits]

So why not keep this patch local as well?

On Sat, Oct 1, 2016, 9:47 AM Saleem Abdulrasool via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> compnerd added a comment.
>
> The patch implicitly has tests: the unit tests generically walks over the
> enumeration, so it is covered by existing tests.
>
> This would allow Facebook to play around with changes that they need for
> local development, which may not necessarily be generic enough or generally
> correct for merging into the mainline.
>
> I don't think that there is any real maintenance cost associated with
> adding the additional vendor triple, especially if it doesnt require
> altering the normal code paths.
>
>
> https://reviews.llvm.org/D25136
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161003/76380fdf/attachment.html>