[PATCH] D25136: [Triple] Add Facebook vendor

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 1 08:47:36 PDT 2016


compnerd added a comment.

The patch implicitly has tests: the unit tests generically walks over the enumeration, so it is covered by existing tests.

This would allow Facebook to play around with changes that they need for local development, which may not necessarily be generic enough or generally correct for merging into the mainline.

I don't think that there is any real maintenance cost associated with adding the additional vendor triple, especially if it doesnt require altering the normal code paths.


https://reviews.llvm.org/D25136





More information about the llvm-commits mailing list