[PATCH] D17467: Instructions: add missing anchors. NFC

[Sanjoy Das via llvm-commits]

+1 to removing vtables.

> The only virtual method left is the destructor, and we can switch-ify that.

Looks like there are a few more, e.g., GlobalValue::copyAttributesFrom

On Fri, Sep 30, 2016 at 11:43 AM, Pete Cooper via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>> On Sep 30, 2016, at 11:31 AM, Reid Kleckner <rnk at google.com> wrote:
>>
>> rnk added a comment.
>>
>> IMO rather than anchoring the vtables we should remove them completely. The only virtual method left is the destructor, and we can switch-ify that.
> I agree.
>
> I had a complete set of patches to do this, but unfortunately some perf concerns were raised.  We never actually attributed any perf regressions to the devirtualisation work, but it did stall the effort as I didn’t want to make the compiler slower.
>
> I can’t remember exactly where I got to, but these are the patch files I had left on my machine, so its likely these are the outstanding ones.  I’m more than happy to rebase these and complete the work if there are no perf issues as I commit.
>
> Pete
>
>
>
>>
>>
>> https://reviews.llvm.org/D17467
>>
>>
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
Sanjoy Das
http://playingwithpointers.com