[PATCH] D17467: Instructions: add missing anchors. NFC

[Pete Cooper via llvm-commits]

> On Sep 30, 2016, at 11:31 AM, Reid Kleckner <rnk at google.com> wrote:
> 
> rnk added a comment.
> 
> IMO rather than anchoring the vtables we should remove them completely. The only virtual method left is the destructor, and we can switch-ify that.
I agree.

I had a complete set of patches to do this, but unfortunately some perf concerns were raised.  We never actually attributed any perf regressions to the devirtualisation work, but it did stall the effort as I didn’t want to make the compiler slower.

I can’t remember exactly where I got to, but these are the patch files I had left on my machine, so its likely these are the outstanding ones.  I’m more than happy to rebase these and complete the work if there are no perf issues as I commit.

Pete

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Devirtualize-getSuccessorV-getNumSuccessorsV-and-set.patch
Type: application/octet-stream
Size: 6834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/278041d6/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Don-t-cast-Constant-to-Value-as-we-will-soon-have-no.patch
Type: application/octet-stream
Size: 1886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/278041d6/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Devirt-GlobalValue-removeFromParent-and-eraseFromPar.patch
Type: application/octet-stream
Size: 5313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/278041d6/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Devirt-GlobalValue-copyAttributesFrom.patch
Type: application/octet-stream
Size: 5496 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/278041d6/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Harden-the-types-of-copyGVAttributes.patch
Type: application/octet-stream
Size: 5833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/278041d6/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Initial-patch-to-remove-the-rest-of-virtual-which-me.patch
Type: application/octet-stream
Size: 72440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/278041d6/attachment-0005.obj>
-------------- next part --------------

> 
> 
> https://reviews.llvm.org/D17467
> 
> 
>