[PATCH] D25094: [ELF] - Linkerscript: cleanup and introduce nextJoined().

[Rui Ueyama via llvm-commits]

But still it is going to be only -6 lines which doesn't seem worth to add
this new convenient function. If you can make the function simpler (in
terms of semantics), I may be convinced, but the current definition of the
function (return the token after the next if the next token is just one
character, or otherwise return the next token) looks too arbitrary.

On Fri, Sep 30, 2016 at 8:27 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> grimar added inline comments.
>
>
> > ruiu wrote in LinkerScript.cpp:1658-1661
> > You removed this error check, so the real delta of this patch is -4
> lines. That's probably too small to introduce a new convenient function.
>
> I know at least one more case when this function can be usefull.
> If we are going to support assigning memory regions one day, it also exist
> in 2 forms in the wild scripts:
>
>   *(.text) } >rom
>   *(.text) } > rom
>
> Probably there are other cases we do not know about yet.
> Generally caller code looks more clean with it then without I think.
>
> https://reviews.llvm.org/D25094
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/9ba450eb/attachment.html>