[PATCH] D25094: [ELF] - Linkerscript: cleanup and introduce nextJoined().
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 30 08:27:52 PDT 2016
grimar added inline comments.
> ruiu wrote in LinkerScript.cpp:1658-1661
> You removed this error check, so the real delta of this patch is -4 lines. That's probably too small to introduce a new convenient function.
I know at least one more case when this function can be usefull.
If we are going to support assigning memory regions one day, it also exist in 2 forms in the wild scripts:
*(.text) } >rom
*(.text) } > rom
Probably there are other cases we do not know about yet.
Generally caller code looks more clean with it then without I think.
https://reviews.llvm.org/D25094
More information about the llvm-commits
mailing list