[llvm] r282665 - LTO: Fix use-after-scope error.
Peter Collingbourne via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 28 20:38:48 PDT 2016
r282678
On Wed, Sep 28, 2016 at 8:24 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
>
> > On Sep 28, 2016, at 6:28 PM, Peter Collingbourne via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
> >
> > Author: pcc
> > Date: Wed Sep 28 20:28:36 2016
> > New Revision: 282665
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=282665&view=rev
> > Log:
> > LTO: Fix use-after-scope error.
> >
> > Modified:
> > llvm/trunk/lib/LTO/LTOBackend.cpp
> >
> > Modified: llvm/trunk/lib/LTO/LTOBackend.cpp
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/
> LTOBackend.cpp?rev=282665&r1=282664&r2=282665&view=diff
> > ============================================================
> ==================
> > --- llvm/trunk/lib/LTO/LTOBackend.cpp (original)
> > +++ llvm/trunk/lib/LTO/LTOBackend.cpp Wed Sep 28 20:28:36 2016
> > @@ -253,6 +253,7 @@ void splitCodeGen(Config &C, TargetMachi
> > std::move(BC), ThreadCount++);
> > },
> > false);
> > + CodegenThreadPool.wait();
>
> I don’t understand this change, and the commit message does not help here.
>
> Can you add a comment in the code clarifying what’s this doing?
>
> Thanks,
>
> —
> Mehdi
>
>
--
--
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160928/404b27c5/attachment.html>
More information about the llvm-commits
mailing list