<div dir="ltr">r282678<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 28, 2016 at 8:24 PM, Mehdi Amini <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On Sep 28, 2016, at 6:28 PM, Peter Collingbourne via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: pcc<br>
> Date: Wed Sep 28 20:28:36 2016<br>
> New Revision: 282665<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=282665&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=282665&view=rev</a><br>
> Log:<br>
> LTO: Fix use-after-scope error.<br>
><br>
> Modified:<br>
>    llvm/trunk/lib/LTO/LTOBackend.<wbr>cpp<br>
><br>
> Modified: llvm/trunk/lib/LTO/LTOBackend.<wbr>cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTOBackend.cpp?rev=282665&r1=282664&r2=282665&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/LTO/<wbr>LTOBackend.cpp?rev=282665&r1=<wbr>282664&r2=282665&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/LTO/LTOBackend.<wbr>cpp (original)<br>
> +++ llvm/trunk/lib/LTO/LTOBackend.<wbr>cpp Wed Sep 28 20:28:36 2016<br>
> @@ -253,6 +253,7 @@ void splitCodeGen(Config &C, TargetMachi<br>
>             std::move(BC), ThreadCount++);<br>
>       },<br>
>       false);<br>
> +  CodegenThreadPool.wait();<br>
<br>
</span>I don’t understand this change, and the commit message does not help here.<br>
<br>
Can you add a comment in the code clarifying what’s this doing?<br>
<br>
Thanks,<br>
<br>
—<br>
<span class="HOEnZb"><font color="#888888">Mehdi<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>