[PATCH] D24492: [LTO] Switch to the new resolution-based API.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 13:09:19 PDT 2016


ruiu added inline comments.

================
Comment at: lld/ELF/LTO.cpp:107
@@ +106,3 @@
+  // Provide a resolution to the LTO API for each symbol.
+  for (auto &ObjSym : Obj.symbols()) {
+    Symbol *Sym = Syms[SymNum];
----------------
auto -> BasicSymbolRef &

================
Comment at: lld/ELF/LTO.cpp:126
@@ -289,1 +125,3 @@
+      undefine(Sym);
     }
+    check(LtoObj->add(std::move(F.Obj), Resols));
----------------
Stray `}`?

================
Comment at: lld/ELF/LTO.cpp:148
@@ +147,3 @@
+  for (unsigned I = 0; I != MaxTasks; ++I) {
+    if (!Buff[I].empty()) {
+      if (Config->SaveTemps) {
----------------
  if (Buff[I].empty())
    continue;



https://reviews.llvm.org/D24492





More information about the llvm-commits mailing list