[PATCH] D24492: [LTO] Switch to the new resolution-based API.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 13:03:11 PDT 2016


davide added inline comments.

================
Comment at: lld/ELF/LTO.cpp:101-102
@@ -169,6 +100,4 @@
 void BitcodeCompiler::add(BitcodeFile &F) {
-  std::unique_ptr<IRObjectFile> Obj = std::move(F.Obj);
-  std::vector<GlobalValue *> Keep;
-  unsigned BodyIndex = 0;
-  ArrayRef<Symbol *> Syms = F.getSymbols();
+  if (HasError)
+    return;
 
----------------
ruiu wrote:
> Why do you want to return here immediately if there was an error before this function?
Ooops, fixed, thanks.


https://reviews.llvm.org/D24492





More information about the llvm-commits mailing list