[PATCH] D24647: [CUDA] [test-suite] Always enable assert()s in our builds.
Artem Belevich via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 27 12:53:00 PDT 2016
tra added a comment.
In https://reviews.llvm.org/D24647#554237, @MatzeB wrote:
> Just took the opportunity to note that setting flags for the whole test-suite in the toplevel CMakeLists.txt is generally a bad idea esp. when there is no way to override it. (As far as options go I would not add a TEST_SUITE_ENABLE_ASSERTIONS, simply because for a normal test-suite user there is little motivation to enable assertions, there is always the option to override the cflags/cxxflags after all).
OK. We'll deal with that if/when we have specific need to enable/disable assertions during config time.
https://reviews.llvm.org/D24647
More information about the llvm-commits
mailing list