[PATCH] D24647: [CUDA] [test-suite] Always enable assert()s in our builds.

[Matthias Braun via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D24647#554226, @tra wrote:

> I guess we need something like -DLLVM_ENABLE_ASSERTIONS=On we use for LLVM to keeps assert enabled in Release build.
>  I'm OK with -UNDEBUG for CUDA until I get a chance to add ENABLE_ASSERTIONS knob (~EOW).


Yes the -UNDEBUG solution is good enough to put into the repo, I did not want to stop the commit.

Just took the opportunity to note that setting flags for the whole test-suite in the toplevel CMakeLists.txt is generally a bad idea esp. when there is no way to override it. (As far as options go I would not add a TEST_SUITE_ENABLE_ASSERTIONS, simply because for a normal test-suite user there is little motivation to enable assertions, there is always the option to override the cflags/cxxflags after all).


https://reviews.llvm.org/D24647