[PATCH] D24818: Using branch probability to guide critical edge splitting.

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: test/CodeGen/X86/phys_subreg_coalesce-2.ll:18
@@ -17,2 +17,3 @@
 ; CHECK-NOT: mov
+; CHECK: jbe
 forbody:		; preds = %forbody, %forcond.preheader
----------------
danielcdh wrote:
> davidxl wrote:
> > What is this change about?
> This patch will sink the mov to critical path, which appears after loop body. So the updates in the test changes to check that there is not "mov" in the loop body, i.e. between "forbody" and "jbe"
should you check there is no move between forcond.preheader and for.body.preheader instead?


https://reviews.llvm.org/D24818