[PATCH] D24818: Using branch probability to guide critical edge splitting.

[Dehao Chen via llvm-commits]

danielcdh added inline comments.

================
Comment at: test/CodeGen/X86/phys_subreg_coalesce-2.ll:18
@@ -17,2 +17,3 @@
 ; CHECK-NOT: mov
+; CHECK: jbe
 forbody:		; preds = %forbody, %forcond.preheader
----------------
davidxl wrote:
> What is this change about?
This patch will sink the mov to critical path, which appears after loop body. So the updates in the test changes to check that there is not "mov" in the loop body, i.e. between "forbody" and "jbe"

================
Comment at: test/CodeGen/X86/pr2659.ll:17
@@ -16,3 +16,3 @@
 ; CHECK: %forcond.preheader
-; CHECK: movl $1
+; CHECK: testl
 ; CHECK-NOT: xorl
----------------
davidxl wrote:
> What is this change about?
The movl $1 will be sinked to critical edge, which is layouted after the loop body.


https://reviews.llvm.org/D24818