[PATCH] D24827: [ARM][LLD] ARM TLS shouldn't use relaxations

[Rafael Avila de Espindola via llvm-commits]

LGTM

On September 23, 2016 5:52:53 AM EDT, Peter Smith <peter.smith at linaro.org> wrote:
>peter.smith updated this revision to Diff 72243.
>peter.smith added a comment.
>
>Updated diff to fix typo and explain the differences between ARM and
>Mips.
>
>I've put the comment as a FIXME as some more work is needed to support
>static linking. In effect we need to hard-code the module index (1 for
>applications) in the GOT rather than getting the dynamic linker to do
>it for us. I think that this should be done in a separate patch as part
>of supporting and testing static linking.
>
>Ed, I think ARMv6 for LLD won't work very well as there are some
>assumptions that ARMv7 instructions are available in interworking
>Thunks and in the encoding of Thumb2 branches. If you can I would
>recommend ARMv7 as a baseline if using LLD. I would like to add this
>support at some point, but it will need some thought as to the best way
>of doing it.
>
>I'll be at a conference myself next week, but I should have some spare
>time to work on stuff as well.
>
>
>https://reviews.llvm.org/D24827
>
>Files:
>  ELF/Relocations.cpp
>  test/ELF/Inputs/arm-tls-get-addr.s
>  test/ELF/arm-tls-norelax-gd-ie.s
>  test/ELF/arm-tls-norelax-gd-le.s
>  test/ELF/arm-tls-norelax-ie-le.s
>  test/ELF/arm-tls-norelax-ld-le.s

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160923/48fd261c/attachment.html>