<html><head></head><body>LGTM<br><br><div class="gmail_quote">On September 23, 2016 5:52:53 AM EDT, Peter Smith <peter.smith@linaro.org> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">peter.smith updated this revision to Diff 72243.<br />peter.smith added a comment.<br /><br />Updated diff to fix typo and explain the differences between ARM and Mips.<br /><br />I've put the comment as a FIXME as some more work is needed to support static linking. In effect we need to hard-code the module index (1 for applications) in the GOT rather than getting the dynamic linker to do it for us. I think that this should be done in a separate patch as part of supporting and testing static linking.<br /><br />Ed, I think ARMv6 for LLD won't work very well as there are some assumptions that ARMv7 instructions are available in interworking Thunks and in the encoding of Thumb2 branches. If you can I would recommend ARMv7 as a baseline if using LLD. I would like to add this support at some point, but it will need some thought as to the best way of doing it.<br /><br />I'll be at a conference myself next week, but I should have some spare time to work on stuff as
well.<br /><br /><br /><a href="https://reviews.llvm.org/D24827">https://reviews.llvm.org/D24827</a><br /><br />Files:<br /> ELF/Relocations.cpp<br /> test/ELF/Inputs/arm-tls-get-addr.s<br /> test/ELF/arm-tls-norelax-gd-ie.s<br /> test/ELF/arm-tls-norelax-gd-le.s<br /> test/ELF/arm-tls-norelax-ie-le.s<br /> test/ELF/arm-tls-norelax-ld-le.s<br /><br /></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>