[PATCH] D24555: [asan] Reify ErrorGeneric

[Filipe Cabecinhas via llvm-commits]

Yes, they were already there. I'm making sure they still work. Later we can
extend them to work for all errors (or maybe have a better API for error
information).

Thank you,
 Filipe

On Tuesday, 20 September 2016, Vitaly Buka <vitalybuka at google.com> wrote:

> vitalybuka accepted this revision.
> vitalybuka added a comment.
> This revision is now accepted and ready to land.
>
> LGTM
> BTW. arc patch https://reviews.llvm.org/D24555 does not work.
>
>
> ================
> Comment at: lib/asan/asan_descriptions.h:230
> @@ -230,1 +229,3 @@
> +        // initialization-order-fiasco has a special Print()
> +        return data.global.Print(bug_descr);
>      }
> ----------------
> Maybe better to extract special address kind for odr?
>
> ================
> Comment at: lib/asan/asan_report.cc:430
> @@ -638,3 +429,3 @@
>  int __asan_report_present() {
> -  return report_happened ? 1 : 0;
> +  return ScopedInErrorReport::CurrentError().kind == kErrorKindGeneric;
>  }
> ----------------
> Why all these only for Generic?
> Is this pre-existed behavior?
>
>
> https://reviews.llvm.org/D24555
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160920/c116f33e/attachment.html>