[PATCH] D24555: [asan] Reify ErrorGeneric

[Vitaly Buka via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

LGTM
BTW. arc patch https://reviews.llvm.org/D24555 does not work.


================
Comment at: lib/asan/asan_descriptions.h:230
@@ -230,1 +229,3 @@
+        // initialization-order-fiasco has a special Print()
+        return data.global.Print(bug_descr);
     }
----------------
Maybe better to extract special address kind for odr?

================
Comment at: lib/asan/asan_report.cc:430
@@ -638,3 +429,3 @@
 int __asan_report_present() {
-  return report_happened ? 1 : 0;
+  return ScopedInErrorReport::CurrentError().kind == kErrorKindGeneric;
 }
----------------
Why all these only for Generic?
Is this pre-existed behavior?


https://reviews.llvm.org/D24555