[llvm] r281618 - Fix silly mistake introduced here : https://reviews.llvm.org/D24566

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 09:28:28 PDT 2016


Should this fix have a targeted test for the transformation itself?

On Thu, Sep 15, 2016 at 8:44 AM Etienne Bergeron via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: etienneb
> Date: Thu Sep 15 10:35:59 2016
> New Revision: 281618
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281618&view=rev
> Log:
> Fix silly mistake introduced here : https://reviews.llvm.org/D24566
> Asan bots are currently broken without this patch.
>
> Modified:
>     llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
>
> Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=281618&r1=281617&r2=281618&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
> (original)
> +++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Thu Sep
> 15 10:35:59 2016
> @@ -1883,7 +1883,7 @@ bool AddressSanitizer::runOnFunction(Fun
>    if (&F == AsanCtorFunction) return false;
>    if (F.getLinkage() == GlobalValue::AvailableExternallyLinkage) return
> false;
>    if (!ClDebugFunc.empty() && ClDebugFunc == F.getName()) return false;
> -  if (F.getName().startswith("__asan_") != std::string::npos) return
> false;
> +  if (F.getName().startswith("__asan_")) return false;
>
>    // If needed, insert __asan_init before checking for SanitizeAddress
> attr.
>    // This function needs to be called even if the function body is not
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160919/b1ea1cc9/attachment.html>


More information about the llvm-commits mailing list