<div dir="ltr">Should this fix have a targeted test for the transformation itself? </div><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 15, 2016 at 8:44 AM Etienne Bergeron via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: etienneb<br class="gmail_msg">
Date: Thu Sep 15 10:35:59 2016<br class="gmail_msg">
New Revision: 281618<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281618&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=281618&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Fix silly mistake introduced here : <a href="https://reviews.llvm.org/D24566" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D24566</a><br class="gmail_msg">
Asan bots are currently broken without this patch.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=281618&r1=281617&r2=281618&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=281618&r1=281617&r2=281618&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Thu Sep 15 10:35:59 2016<br class="gmail_msg">
@@ -1883,7 +1883,7 @@ bool AddressSanitizer::runOnFunction(Fun<br class="gmail_msg">
   if (&F == AsanCtorFunction) return false;<br class="gmail_msg">
   if (F.getLinkage() == GlobalValue::AvailableExternallyLinkage) return false;<br class="gmail_msg">
   if (!ClDebugFunc.empty() && ClDebugFunc == F.getName()) return false;<br class="gmail_msg">
-  if (F.getName().startswith("__asan_") != std::string::npos) return false;<br class="gmail_msg">
+  if (F.getName().startswith("__asan_")) return false;<br class="gmail_msg">
<br class="gmail_msg">
   // If needed, insert __asan_init before checking for SanitizeAddress attr.<br class="gmail_msg">
   // This function needs to be called even if the function body is not<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>