[PATCH] D23933: [XRay] ARM 32-bit no-Thumb support in compiler-rt

[Renato Golin via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D23933#546267, @rSerge wrote:

> `armv6t2` shouldn't work because MOVW and MOVT instructions are available only since armv7.


Movw/Movt are Thumb2 instructions and  were introduced in ARMv6T2.

> I can test with `.fpu vfpv2`, though this is not quick (compilation and moving between VMs takes substantial time).


I'm not worried about the assembly code working on v6T2 or VFPv2, I'm worried about the toolchain coping with the options.

You just need to get the complete command line with a recent enough cross-toolchain (4.8+) and try on the resulting file.

cheers,
--renato

PS: You should really get the ARM ARMs: http://llvm.org/docs/CompilerWriterInfo.html


================
Comment at: lib/xray/xray_arm.cc:1
@@ +1,2 @@
+//===-- xray_arm.cpp --------------------------------------------*- C++ -*-===//
+//
----------------
rSerge wrote:
> dberris wrote:
> > nit: s/xray_arm.cpp/xray_arm.cc/
> Sorry, I'm not that good with the lingo. What is the meaning of this comment?
It means the name on the comment is wrong and you have to *replace* (s///) with the right one.

You're calling it `xray_arm.cc` but has `xray_arm.cpp` in the header.


https://reviews.llvm.org/D23933