[PATCH] D23933: [XRay] ARM 32-bit no-Thumb support in compiler-rt

[Serge Rogatch via llvm-commits]

rSerge added a comment.

In https://reviews.llvm.org/D23933#544817, @rengolin wrote:

> So, you're forcing vfpv3, which is armv7-only. AFAICS, you're only using VPUSH and VPOP, which is available since vfpv2 (which is also available in v6), so maybe a better fix would be to use:
>
>   .arch armv6t2
>   .fpu vfpv2
>   
>
> which should work on armv7, too.
>
> Since this is the restriction we have inside the code, it would be more clear this way. Can you do a quick test with those directives?
>
> cheers,
> --renato


`armv6t2` shouldn't work because MOVW and MOVT instructions are available only since armv7 .
I can test with `.fpu vfpv2`, though this is not quick.


================
Comment at: lib/xray/xray_arm.cc:1
@@ +1,2 @@
+//===-- xray_arm.cpp --------------------------------------------*- C++ -*-===//
+//
----------------
dberris wrote:
> nit: s/xray_arm.cpp/xray_arm.cc/
Sorry, I'm not that good with the lingo. What is the meaning of this comment?


https://reviews.llvm.org/D23933