[PATCH] D24650: [ELF] - Linkerscript: PR30387 - cannot handle EXCLUDE_FILE in the middle of a input section description.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 05:51:34 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:990
@@ +989,3 @@
+void ScriptParser::readSectionExcludes(InputSectionDescription *Cmd) {
+  llvm::Regex ExcludeFileRe;
+  std::vector<StringRef> V;
----------------
rafael wrote:
> The default constructed RE matches anything?
Nope, even do not tries, returns no match found instantly as it is in "error state".


https://reviews.llvm.org/D24650





More information about the llvm-commits mailing list