[PATCH] D24650: [ELF] - Linkerscript: PR30387 - cannot handle EXCLUDE_FILE in the middle of a input section description.

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: ELF/LinkerScript.cpp:989
@@ -983,1 +988,3 @@
 
+void ScriptParser::readSectionExcludes(InputSectionDescription *Cmd) {
+  llvm::Regex ExcludeFileRe;
----------------
Add a comment saying what this parses, which i think is

((EXCLUDE_FILE(file_patterrn+))?  section_pattern+)+

================
Comment at: ELF/LinkerScript.cpp:990
@@ +989,3 @@
+void ScriptParser::readSectionExcludes(InputSectionDescription *Cmd) {
+  llvm::Regex ExcludeFileRe;
+  std::vector<StringRef> V;
----------------
The default constructed RE matches anything?


https://reviews.llvm.org/D24650